Skip to content

Fix statistics doing I/O in the event loop#68315

Merged
bdraco merged 5 commits intohome-assistant:devfrom
bdraco:stats_io_eloop
Mar 18, 2022
Merged

Fix statistics doing I/O in the event loop#68315
bdraco merged 5 commits intohome-assistant:devfrom
bdraco:stats_io_eloop

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 17, 2022

Proposed change

Fix statistics doing I/O in the event loop

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco requested a review from fabaff as a code owner March 17, 2022 22:23
@probot-home-assistant probot-home-assistant bot added integration: statistics small-pr PRs with less than 30 lines. labels Mar 17, 2022
@bdraco bdraco marked this pull request as draft March 17, 2022 22:23
@probot-home-assistant
Copy link
Copy Markdown

Hey there @fabaff, @ThomDietrich, mind taking a look at this pull request as it has been labeled with an integration (statistics) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery
Copy link
Copy Markdown
Contributor

It's really not so nice that statistics and plant access the database directly instead of via the history or logbook APIs.

@bdraco bdraco marked this pull request as ready for review March 18, 2022 09:12
@bdraco bdraco marked this pull request as draft March 18, 2022 09:14
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 18, 2022

Actually lets merge #68224 first since this will conflict with that one as well and this one is easier to resolve the conflict in

@bdraco bdraco marked this pull request as ready for review March 18, 2022 10:29
@bdraco bdraco merged commit b284edd into home-assistant:dev Mar 18, 2022
@bdraco bdraco deleted the stats_io_eloop branch March 18, 2022 10:49
@ThomDietrich
Copy link
Copy Markdown
Contributor

@emontnemery I agree. I never touched this part of the statistics component but dislike the duplication of state memory. We should discuss whether a transition to a direct link to the history is preferred.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

statistics/sensor.py does I/O in the event loop

6 participants